ayush00git commented on code in PR #3374: URL: https://github.com/apache/fory/pull/3374#discussion_r2895894784
########## go/fory/stream.go: ########## @@ -0,0 +1,164 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package fory + +import ( + "io" + "reflect" +) + +// InputStream supports robust sequential deserialization from a stream. +// It maintains the ByteBuffer and ReadContext state across multiple Deserialize calls, +// preventing data loss from prefetched buffers and preserving TypeResolver metadata +// (Meta Sharing) across object boundaries. +type InputStream struct { + buffer *ByteBuffer +} + +// NewInputStream creates a new InputStream that reads from the provided io.Reader. +// The InputStream owns the buffer and maintains state across sequential Deserialize calls. +func NewInputStream(r io.Reader) *InputStream { + return NewInputStreamWithMinCap(r, 0) +} + +// NewInputStreamWithMinCap creates a new InputStream with a specified minimum buffer capacity. +func NewInputStreamWithMinCap(r io.Reader, minCap int) *InputStream { Review Comment: i'll change it to NewInputStreamWithBufferSize. does that sounds good ? It would also resonate with the api implemented in the cpp strem deserialization -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
