chaokunyang commented on PR #3482: URL: https://github.com/apache/fory/pull/3482#issuecomment-4208165734
> Thanks for the review! Now, For the codegen path, if Ids are out of range it fall back to ordinal serialization with a warning while `EnumSerializer.write()` throw a `RangeError` for manually constructed specs. Is this fine? Or shall we also give a hard error through the codegen? Need strict errors instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
