chaokunyang commented on PR #3482: URL: https://github.com/apache/fory/pull/3482#issuecomment-4211208709
> I've added the round-trip tests and updated for out-of-range. Should `missingIdValues` and `duplicateIds` also be strict? I think they cause a similar problem. Yes. missingIdValues and duplicateIds should also be strict. The rule should be: - No @ForyEnumId anywhere: use ordinal mode. - Any @ForyEnumId present: the whole enum ID configuration must be valid, or codegen should fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
