PragmaTwice commented on code in PR #1326: URL: https://github.com/apache/incubator-fury/pull/1326#discussion_r1447497763
########## src/fury/encoder/row_encode_trait.h: ########## @@ -17,7 +17,8 @@ * under the License. */ -#pragma once +#ifndef __ROW_ENCODER_TRAIT_HEADER +#define __ROW_ENCODER_TRAIT_HEADER Review Comment: https://learn.microsoft.com/en-us/cpp/preprocessor/pragma-directives-and-the-pragma-keyword?view=msvc-170 from this page, we can see that it is supported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
