PragmaTwice commented on code in PR #1326: URL: https://github.com/apache/incubator-fury/pull/1326#discussion_r1447499155
########## src/fury/encoder/row_encode_trait.h: ########## @@ -17,7 +17,8 @@ * under the License. */ -#pragma once +#ifndef __ROW_ENCODER_TRAIT_HEADER +#define __ROW_ENCODER_TRAIT_HEADER Review Comment: And also, here is a live example on godbolt: https://godbolt.org/z/xevh3Ejoj > Is it more versatile if we use this method? It is not related to this PR. Feel free to open issue or a seperate PR for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
