LiangliangSui commented on issue #1457: URL: https://github.com/apache/incubator-fury/issues/1457#issuecomment-2033966875
Hi @pushrsp ，thanks for your suggession. Regarding your first proposal, I think it is unnecessary, we use one byte to store the value of boolean type. We can also know it from the code `UNSAFE.putByte(heapMemory, pos, (byte) (value ? 1 : 0));` below, so `writerIdx + 1` itself is easy to understand. Regarding the second suggestion, how to simplify it? Extract a function separately for the checked logic and call it in readXXX? cc @chaokunyang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
