LiangliangSui commented on issue #1457: URL: https://github.com/apache/incubator-fury/issues/1457#issuecomment-2034053238
LGTM. We don't have to worry about `throwIfOutOfBound` function not being inlined because `throwIfOutOfBound` is rarely executed. BTW, we can also use [throwIndexOutOfBoundsException function](https://github.com/apache/incubator-fury/blob/main/java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java#L1866-L1870) to replace `throw new IndexOutOfBoundsException(...)`. What do you think about this suggestion? @chaokunyang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
