LiangliangSui commented on PR #1480: URL: https://github.com/apache/incubator-fury/pull/1480#issuecomment-2044028789
> There are so many `get/put/read/write` `short/int/long/float/double`, change it all to `int16/32/64`/`float16/32/64` will be a huge change. > > One solution is that we can keep old naming intact, and add new names too. i.e. `readInt32/readInt` exists at the same time I prefer not to exist simultaneously, as existing at the same time will lead to more confusion of concepts and bloated code base. The current PR has modified the common interface in [MemoryBuffer(e.g. writePositiveVarInt -> writeVarUint32)](https://github.com/apache/incubator-fury/pull/1480/files#diff-f321dd2324a9ae0cd5808f0281fd200090a9175830937aa3fb48cf309f7e36a1R1136-R1142), which has had an impact on some custom serializers. Now that this compatibility has been broken, we can complete all the renaming work before releasing pkg under `org.apache.fury`. We won't be able to make such more dangerous modifications in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
