tommyettinger commented on PR #1480: URL: https://github.com/apache/incubator-fury/pull/1480#issuecomment-2051421835
I have no problem using Float32 and Int64 etc. as the terms, I think they're language-neutral and are almost completely self-explanatory. I imagine anyone writing code that uses MemoryBuffer won't have any problem knowing what Float32 vs Float64 mean. In C, I know `long` has some sort of compiler- and architecture-dependent meaning, and also that there's `long long` (which would not be good to see in a method name in other languages, since it looks like a pair of `long`s). So moving towards the types of numbers that at least C++ seems to encourage, like how it has int64_t, should be a good action. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
