chaokunyang commented on PR #1485: URL: https://github.com/apache/incubator-fury/pull/1485#issuecomment-2045512782
> We cannot guarantee that `Log.debug` will not be used. If `Log.debug` is used in some frequently executed locations, a large amount of logs will be output because we have no level control. > > Maybe we can open an Issue and add the `good first use` tag to provide training opportunities for new developers who want to join the Fury community. This need is not very urgent for us. The debug log should be avoided in critical path. But I agree with you that we can provide log level for reduce info and other logs print. I prefer not to provide debug api in fury Logger. Without this API, users won't print debug log. The log level api has its cost too. Jvm can't eliminate the condition checks, you can see how kryo use a static final constant to reduce the log cost -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
