chaokunyang commented on PR #1485: URL: https://github.com/apache/incubator-fury/pull/1485#issuecomment-2046382532
> > But I agree with you that we can provide log level for reduce info and other logs print. > > Yes, we can control the output of other levels of Log. > > > The log level api has its cost too. Jvm can't eliminate the condition checks, you can see how kryo use a static final constant to reduce the log cost > > FuryLogger is only used internally. We can add a `static final` Level field in FuryLogger to control the output Log level. In this way, Log Level does not support dynamic setting. Nice, looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
