chaokunyang commented on code in PR #1525:
URL: https://github.com/apache/incubator-fury/pull/1525#discussion_r1567105581
##########
java/fury-core/src/main/java/org/apache/fury/pool/ClassLoaderFuryPooled.java:
##########
@@ -122,6 +124,20 @@ private void addFury() {
}
void setFactoryCallback(Consumer<Fury> factoryCallback) {
Review Comment:
This method should not be called concurently, users should invoke regitster
and other fury config methods when creating ThreadSafeFury. It's not necessary
to add a lock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
