LiangliangSui commented on code in PR #1525:
URL: https://github.com/apache/incubator-fury/pull/1525#discussion_r1567212869
##########
java/fury-core/src/main/java/org/apache/fury/pool/ClassLoaderFuryPooled.java:
##########
@@ -122,6 +124,20 @@ private void addFury() {
}
void setFactoryCallback(Consumer<Fury> factoryCallback) {
Review Comment:
In fact, all our register and config functions should be called when
`ThreadSafeFury` is being created, but the purpose of adding the
`processCallback` function should be contrary to this design. The
`processCallback` interface allows register or config operations to be
performed after created `ThreadSafeFury`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
