chaokunyang commented on code in PR #1553:
URL: https://github.com/apache/incubator-fury/pull/1553#discussion_r1577734063
##########
java/fury-core/src/main/java/org/apache/fury/builder/CodecBuilder.java:
##########
@@ -84,23 +84,23 @@ public abstract class CodecBuilder {
protected static final String ROOT_OBJECT_NAME = "obj";
// avoid user class has field with name fury.
protected static final String FURY_NAME = "fury";
- static TypeToken<Object[]> objectArrayTypeToken =
TypeToken.of(Object[].class);
- static TypeToken<MemoryBuffer> bufferTypeToken =
TypeToken.of(MemoryBuffer.class);
- static TypeToken<ClassInfo> classInfoTypeToken =
TypeToken.of(ClassInfo.class);
- static TypeToken<ClassInfoHolder> classInfoHolderTypeToken =
TypeToken.of(ClassInfoHolder.class);
+ static TypeRef<Object[]> objectArrayTypeToken = TypeRef.of(Object[].class);
Review Comment:
Could we rename all `xxxTypeToken` into `xxxTypeRef`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
