chaokunyang commented on code in PR #1553:
URL: https://github.com/apache/incubator-fury/pull/1553#discussion_r1577736753
##########
java/fury-core/src/main/java/org/apache/fury/type/GenericType.java:
##########
@@ -46,7 +46,7 @@ public class GenericType {
}
};
- final TypeToken<?> typeToken;
+ final TypeRef<?> typeToken;
Review Comment:
```suggestion
final TypeRef<?> typeRef;
```
##########
java/fury-core/src/main/java/org/apache/fury/type/GenericType.java:
##########
@@ -58,9 +58,9 @@ public class GenericType {
Serializer<?> serializer;
private Boolean trackingRef;
- public GenericType(TypeToken<?> typeToken, boolean isMonomorphic,
GenericType... typeParameters) {
- this.typeToken = typeToken;
- this.cls = getRawType(typeToken);
+ public GenericType(TypeRef<?> typeRef, boolean isMonomorphic, GenericType...
typeParameters) {
+ this.typeToken = typeRef;
Review Comment:
```suggestion
this.typeRef = typeRef;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
