waynexia commented on code in PR #1662:
URL: https://github.com/apache/incubator-fury/pull/1662#discussion_r1620201716
##########
rust/fury-derive/Cargo.toml:
##########
@@ -25,7 +25,12 @@ rust-version.workspace = true
proc-macro = true
[dependencies]
-proc-macro2 = { default-features = false, version = "1.0.66" }
Review Comment:
Cargo will try to resolve the "latest" package version that meets the semver
rule. Hence the last patch version in Cargo.toml doesn't take efforts, unless
use a strict match like `version = "=1.0.66"`
##########
rust/tests/tests/test_complex_struct.rs:
##########
@@ -60,7 +60,7 @@ fn complex_struct() {
op: Some("option".to_string()),
op2: None,
date: NaiveDate::from_ymd_opt(2025, 12, 12).unwrap(),
- time: NaiveDateTime::from_timestamp_opt(1689912359, 0).unwrap(),
+ time: DateTime::from_timestamp(1689912359, 0).unwrap().naive_utc(),
Review Comment:
The semantic doesn't changes:
https://docs.rs/chrono/latest/chrono/struct.NaiveDateTime.html#method.from_timestamp_opt
The previous call `NaiveDateTime::from_timestamp_opt` also returns UTC
datetime
>Makes a new NaiveDateTime corresponding to a UTC date and time, from the
number of non-leap seconds since the midnight UTC on January 1, 1970 (aka “UNIX
timestamp”) and the number of nanoseconds since the last whole non-leap second.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
