chaokunyang commented on PR #1675: URL: https://github.com/apache/fury/pull/1675#issuecomment-2173226645
> I went through the https://www.conventionalcommits.org/en/v1.0.0/ but I still manage to fail the lint test. > > > Do we need to merge those three classes into one file named metastring.ts? > > I am still studying the structure of the apache furry code base. I don't really know much but I think it's best to use the same file structure as the ones in the `java` code base , so that it will be easier for new developers to navigate through. I prefer keeping javascript idioms. In fury python, all those three class will be put int one file named `metastring.py`. We won't get a fully consistent file layout across language. @theweipeng How javascript organize such classes ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
