chaokunyang commented on code in PR #1708:
URL: https://github.com/apache/fury/pull/1708#discussion_r1659516416


##########
java/fury-core/src/main/java/org/apache/fury/util/StringUtils.java:
##########
@@ -22,12 +22,28 @@
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Random;
+import org.apache.fury.memory.Platform;
 
 public class StringUtils {
+  // A long mask used to clear all-higher bits of char in a super-word way.
+  public static final long MULTI_CHARS_NON_LATIN_MASK;

Review Comment:
   ```suggestion
     private static final long MULTI_CHARS_NON_LATIN_MASK;
   ```



##########
java/fury-core/src/test/java/org/apache/fury/util/StringUtilsTest.java:
##########
@@ -23,9 +23,11 @@
 import static org.testng.Assert.assertFalse;
 import static org.testng.Assert.assertTrue;
 
+import org.apache.fury.FuryTestBase;
+import org.apache.fury.memory.Platform;
 import org.testng.annotations.Test;
 
-public class StringUtilsTest {
+public class StringUtilsTest extends FuryTestBase {

Review Comment:
   ```suggestion
   public class StringUtilsTest {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to