anagh07 commented on code in PR #1708:
URL: https://github.com/apache/fury/pull/1708#discussion_r1659498757


##########
java/fury-core/src/main/java/org/apache/fury/util/StringUtils.java:
##########
@@ -249,4 +265,30 @@ public static String lowerCamelToLowerUnderscore(String 
lowerCamel) {
 
     return builder.toString();
   }
+
+  public static boolean isLatin(char[] chars, int charArrayOffset) {

Review Comment:
   A `StringUtils` interface?



##########
java/fury-core/src/test/java/org/apache/fury/util/StringUtilsTest.java:
##########
@@ -23,9 +23,11 @@
 import static org.testng.Assert.assertFalse;
 import static org.testng.Assert.assertTrue;
 
+import org.apache.fury.FuryTestBase;
+import org.apache.fury.memory.Platform;
 import org.testng.annotations.Test;
 
-public class StringUtilsTest {
+public class StringUtilsTest extends FuryTestBase {

Review Comment:
   `StringUtilsTest.testVectorizedLatinCheckAlgorithm(boolean)` asks for a 
`@Dataprovider` named "endian"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to