urlyy commented on PR #1775: URL: https://github.com/apache/fury/pull/1775#issuecomment-2254241005
I learned the technique used in https://github.com/simdutf/simdutf , and implemented in fury. Here are some questions: 1. Sorry for I can only test on x86 platform. I rely on GitHub CI to debug the logic of the AArch64 version.😢 I can't give the aarch64 benchmark data. 2. There may be a lot of comments. If they are not desired , I will remove them. 3. I have seen another SIMD code in rust , `string_util.rs`, should I merge it with my code like what has done in `cpp`? 4. As it is helpful to use the precomputing table, I have put it in my code , but takes approximately 1600 lines. Do you have some advice on this? 5. For better readability, I have used nested mod and divided the various steps into different functions. If this approach is not satisfactory, I am willing to make adjustments。 6. To be honest, I am uncertain whether introducing such an extensive amount of code is justified merely for the purpose of converting UTF to UTF-8. However, I have observed optimizations, particularly for the conversion of 1 UTF-16 to 1, 2, or 3 UTF-8 bytes. This has added complexity。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
