xxd819240366 commented on code in PR #1791:
URL: https://github.com/apache/fury/pull/1791#discussion_r1704179050
##########
java/fury-core/src/main/java/org/apache/fury/resolver/EnumStringResolver.java:
##########
@@ -0,0 +1,46 @@
+package org.apache.fury.resolver;
+
+import org.apache.fury.memory.MemoryBuffer;
+import org.apache.fury.meta.MetaString;
+
+import static org.apache.fury.meta.Encoders.GENERIC_DECODER;
+import static org.apache.fury.meta.Encoders.GENERIC_ENCODER;
+
+public class EnumStringResolver {
Review Comment:
because
org.apache.fury.resolver.MetaStringResolver#getOrCreateMetaStringBytes is not
public and MetaStringBytes annotated by @Internal. I feel like I shouldn't
break the existing design
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
