chaokunyang commented on code in PR #1791:
URL: https://github.com/apache/fury/pull/1791#discussion_r1723169022
##########
java/fury-core/src/main/java/org/apache/fury/serializer/NonexistentClassSerializers.java:
##########
@@ -241,13 +252,40 @@ public Object read(MemoryBuffer buffer) {
return enumConstants[ordinal];
}
}
+ public static final class NonexistentEnumByNameClassSerializer extends
Serializer {
+ private final Map<MetaStringBytes, NonexistentEnum> enumMap;
+ private final MetaStringResolver metaStringResolver;
+
+ public NonexistentEnumByNameClassSerializer(Fury fury) {
+ super(fury, NonexistentEnum.class);
+ metaStringResolver = new MetaStringResolver();
+ NonexistentEnum[] enumConstants =
NonexistentEnum.class.getEnumConstants();
+ enumMap = Arrays.stream(enumConstants)
+ .map(e -> {
+ MetaStringBytes stringBytes =
+
this.metaStringResolver.getOrCreateMetaStringBytes(GENERIC_ENCODER.encode(e.name(),
MetaString.Encoding.UTF_8));
+ return new AbstractMap.SimpleEntry<>(stringBytes, e);
+ })
+ .collect(Collectors.toMap(AbstractMap.SimpleEntry::getKey,
AbstractMap.SimpleEntry::getValue));
+ }
+ @Override
+ public Enum read(MemoryBuffer buffer) {
+ MetaStringBytes metaStringBytes =
metaStringResolver.readMetaStringBytes(buffer);
+ if (!enumMap.containsKey(metaStringBytes)) {
+ Optional<NonexistentEnum> first =
enumMap.values().stream().findFirst();
+ return first.orElse(null);
+ }
+ return enumMap.get(metaStringBytes);
Review Comment:
This introduce a second map loopkup, we should avoid it. we can `value =
enumMap.get(xxx);` and check whether `value` is null instead of check by
`containsKey`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
