chaokunyang commented on code in PR #2036:
URL: https://github.com/apache/fury/pull/2036#discussion_r2051405254
##########
java/fury-core/src/main/java/org/apache/fury/serializer/CompatibleSerializer.java:
##########
@@ -599,14 +616,15 @@ private Object readFieldValue(FieldResolver.FieldInfo
fieldInfo, MemoryBuffer bu
case ClassResolver.PRIMITIVE_DOUBLE_CLASS_ID:
return buffer.readFloat64();
case ClassResolver.STRING_CLASS_ID:
- return fury.readJavaStringRef(buffer);
+ return fury.readJavaStringRef(buffer,
fieldInfo.getFuryFieldAnnotationInfo().nullable);
Review Comment:
Could we add a nullbale field into `fieldInfo` directly to avoid two
indirections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
