chaokunyang commented on code in PR #2036:
URL: https://github.com/apache/fury/pull/2036#discussion_r2051407156
##########
java/fury-core/src/main/java/org/apache/fury/serializer/ObjectSerializer.java:
##########
@@ -495,104 +548,165 @@ static boolean writePrimitiveFieldValueFailed(
* @return true if field value isn't written by this function.
*/
static boolean writeBasicObjectFieldValueFailed(
- Fury fury, MemoryBuffer buffer, Object fieldValue, short classId) {
+ Fury fury,
Review Comment:
How about adding a new `writeBasicNullableObjectFieldValueFailed` method? In
this method, we handle nullability, and in `writeBasicObjectFieldValueFailed`,
all fields are not null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
