david1437 commented on code in PR #2218:
URL: https://github.com/apache/fury/pull/2218#discussion_r2084242117


##########
java/fury-core/src/main/java/org/apache/fury/serializer/ArraySerializers.java:
##########
@@ -208,6 +251,30 @@ private Object[] newArray(int numElements) {
       }
       return value;
     }
+
+    private GenericType buildCollectionGenericType(int dimensions) {

Review Comment:
   Apologies if it is a dumb question, but where is collectionTypeRef coming 
from in this case? I was thinking it might be TypeUtils.COLLECTION_TYPE but 
even in this case its adding one element for looping over multiple dimensions 
so would still fail



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to