david1437 commented on code in PR #2218:
URL: https://github.com/apache/fury/pull/2218#discussion_r2084486090
##########
java/fury-core/src/main/java/org/apache/fury/serializer/ArraySerializers.java:
##########
@@ -69,12 +76,23 @@ public ObjectArraySerializer(Fury fury, Class<T[]> cls) {
if (fury.getClassResolver().isMonomorphic(componentType)) {
if (fury.isCrossLanguage()) {
this.componentTypeSerializer = null;
+ this.collectionSerializer = null;
+ this.collectionGenericType = null;
} else {
this.componentTypeSerializer =
fury.getClassResolver().getSerializer(componentType);
+ if (dimension > 1) {
+ this.collectionSerializer = new FuryArrayAsListSerializer(fury);
+ this.collectionGenericType = buildCollectionGenericType(dimension);
+ } else {
+ this.collectionSerializer = null;
Review Comment:
Ok I am under impression T[] can never have primitives only wrapper
primitive classes should those use predvious method as well ie. Double[] ?
##########
java/fury-core/src/main/java/org/apache/fury/serializer/ArraySerializers.java:
##########
@@ -69,12 +76,23 @@ public ObjectArraySerializer(Fury fury, Class<T[]> cls) {
if (fury.getClassResolver().isMonomorphic(componentType)) {
if (fury.isCrossLanguage()) {
this.componentTypeSerializer = null;
+ this.collectionSerializer = null;
+ this.collectionGenericType = null;
} else {
this.componentTypeSerializer =
fury.getClassResolver().getSerializer(componentType);
+ if (dimension > 1) {
+ this.collectionSerializer = new FuryArrayAsListSerializer(fury);
+ this.collectionGenericType = buildCollectionGenericType(dimension);
+ } else {
+ this.collectionSerializer = null;
Review Comment:
Ok I am under impression T[] can never have primitives only wrapper
primitive classes should those use previous method as well ie. Double[] ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
