chaokunyang commented on code in PR #2168:
URL: https://github.com/apache/fury/pull/2168#discussion_r2084432219
##########
java/fury-core/src/main/java/org/apache/fury/serializer/MetaSharedSerializer.java:
##########
@@ -230,13 +232,15 @@ private void readFields(MemoryBuffer buffer, Object[]
fields) {
}
}
for (ObjectSerializer.GenericTypeField fieldInfo : otherFields) {
- Object fieldValue =
AbstractObjectSerializer.readOtherFieldValue(binding, fieldInfo, buffer);
+ Object fieldValue =
+ AbstractObjectSerializer.readOtherFieldValue(binding, refResolver,
fieldInfo, buffer);
fields[counter++] = fieldValue;
}
Generics generics = fury.getGenerics();
for (ObjectSerializer.GenericTypeField fieldInfo : containerFields) {
Object fieldValue =
- AbstractObjectSerializer.readContainerFieldValue(binding, generics,
fieldInfo, buffer);
+ AbstractObjectSerializer.readContainerFieldValue(
+ binding, refResolver, generics, fieldInfo, buffer);
Review Comment:
We could hold refResolver as a field in binding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
