chaokunyang commented on code in PR #2168:
URL: https://github.com/apache/fury/pull/2168#discussion_r2084626267
##########
java/fury-core/src/main/java/org/apache/fury/serializer/AbstractObjectSerializer.java:
##########
@@ -126,15 +124,14 @@ static Object readFinalObjectFieldValue(
static Object readOtherFieldValue(
SerializationBinding binding,
- RefResolver refResolver,
GenericTypeField fieldInfo,
MemoryBuffer buffer) {
Object fieldValue;
boolean nullable = fieldInfo.nullable;
if (fieldInfo.trackingRef) {
fieldValue = binding.readRef(buffer, fieldInfo);
} else {
- refResolver.preserveRefId(-1);
+ binding.preserveRefId(-1);
Review Comment:
how about moving this just before `fieldValue = binding.readNonRef(buffer,
fieldInfo);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
