Philipp Hörist pushed to branch master at gajim / gajim

Commits:
cb65cfc5 by Philipp Hörist at 2017-05-26T23:10:05+02:00
Add config option to activate XEP-0146 commands

Some of the Commands have security implications, thats why we disable them per 
default
Fixes #8378

- - - - -


2 changed files:

- src/common/commands.py
- src/common/config.py


Changes:

=====================================
src/common/commands.py
=====================================
--- a/src/common/commands.py
+++ b/src/common/commands.py
@@ -345,9 +345,10 @@ class ConnectionCommands:
     def __init__(self):
         # a list of all commands exposed: node -> command class
         self.__commands = {}
-        for cmdobj in (ChangeStatusCommand, ForwardMessagesCommand,
-        LeaveGroupchatsCommand, FwdMsgThenDisconnectCommand):
-            self.__commands[cmdobj.commandnode] = cmdobj
+        if gajim.config.get('remote_commands'):
+            for cmdobj in (ChangeStatusCommand, ForwardMessagesCommand,
+            LeaveGroupchatsCommand, FwdMsgThenDisconnectCommand):
+                self.__commands[cmdobj.commandnode] = cmdobj
 
         # a list of sessions; keys are tuples (jid, sessionid, node)
         self.__sessions = {}


=====================================
src/common/config.py
=====================================
--- a/src/common/config.py
+++ b/src/common/config.py
@@ -315,6 +315,7 @@ class Config:
             'show_avatar_in_tabs': [ opt_bool, False, _('Show a mini avatar in 
chat window tabs and in window icon')],
             'use_keyring': [opt_bool, True, _('If True, Gajim will use the 
Systems Keyring to store account passwords.')],
             'pgp_encoding': [ opt_str, '', _('Sets the encoding used by 
python-gnupg'), True],
+            'remote_commands': [opt_bool, False, _('If True, Gajim will 
execute XEP-0146 Commands.')],
     }, {})
 
     __options_per_key = {



View it on GitLab: 
https://dev.gajim.org/gajim/gajim/commit/cb65cfc5aed9efe05208ebbb7fb2d41fcf7253cc
_______________________________________________
Commits mailing list
[email protected]
https://lists.gajim.org/cgi-bin/listinfo/commits

Reply via email to