Philipp Hörist pushed to branch gajim_0.16 at gajim / gajim

Commits:
b567bba5 by Philipp Hörist at 2017-05-26T23:55:06+02:00
Add config option to activate XEP-0146 commands

Some of the Commands have security implications, thats why we disable them per 
default
Fixes #8378

- - - - -


2 changed files:

- src/common/commands.py
- src/common/config.py


Changes:

=====================================
src/common/commands.py
=====================================
--- a/src/common/commands.py
+++ b/src/common/commands.py
@@ -345,9 +345,10 @@ class ConnectionCommands:
     def __init__(self):
         # a list of all commands exposed: node -> command class
         self.__commands = {}
-        for cmdobj in (ChangeStatusCommand, ForwardMessagesCommand,
-        LeaveGroupchatsCommand, FwdMsgThenDisconnectCommand):
-            self.__commands[cmdobj.commandnode] = cmdobj
+        if gajim.config.get('remote_commands'):
+            for cmdobj in (ChangeStatusCommand, ForwardMessagesCommand,
+            LeaveGroupchatsCommand, FwdMsgThenDisconnectCommand):
+                self.__commands[cmdobj.commandnode] = cmdobj
 
         # a list of sessions; keys are tuples (jid, sessionid, node)
         self.__sessions = {}


=====================================
src/common/config.py
=====================================
--- a/src/common/config.py
+++ b/src/common/config.py
@@ -315,6 +315,7 @@ class Config:
             'remember_opened_chat_controls': [ opt_bool, True, _('If enabled, 
Gajim will reopen chat windows that were opened last time Gajim was closed.')],
             'positive_184_ack': [ opt_bool, False, _('If enabled, Gajim will 
show an icon to show that sent message has been received by your contact')],
             'pgp_encoding': [ opt_str, '', _('Sets the encoding used by 
python-gnupg'), True],
+            'remote_commands': [opt_bool, False, _('If True, Gajim will 
execute XEP-0146 Commands.')],
     }, {})
 
     __options_per_key = {



View it on GitLab: 
https://dev.gajim.org/gajim/gajim/commit/b567bba56c814e8834e4fca3ee4acbb54ac159c1
_______________________________________________
Commits mailing list
[email protected]
https://lists.gajim.org/cgi-bin/listinfo/commits

Reply via email to