yma11 commented on code in PR #4859:
URL: https://github.com/apache/incubator-gluten/pull/4859#discussion_r1517130257
##########
shims/spark34/src/main/scala/io/glutenproject/sql/shims/spark34/Spark34Shims.scala:
##########
@@ -252,4 +254,45 @@ class Spark34Shims extends SparkShims {
def getAnalysisExceptionPlan(ae: AnalysisException): Option[LogicalPlan] = {
ae.plan
}
+
+ override def getKeyGroupedPartitioning(batchScan: BatchScanExec):
Option[Seq[Expression]] = {
+ batchScan.keyGroupedPartitioning
+ }
+
+ override def getCommonPartitionValues(
+ batchScan: BatchScanExec): Option[Seq[(InternalRow, Int)]] = {
+ batchScan.commonPartitionValues
+ }
+
+ override def orderPartitions(
Review Comment:
Shouldn't have the partitions distribution been done at plan analysis
phase? Why do we need to add this step at transformer layer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
