SinghAsDev commented on code in PR #4859:
URL: https://github.com/apache/incubator-gluten/pull/4859#discussion_r1521849064
##########
gluten-iceberg/src/test/scala/io/glutenproject/execution/VeloxIcebergSuite.scala:
##########
@@ -56,44 +71,246 @@ class VeloxIcebergSuite extends WholeStageTransformerSuite
{
}
}
- test("iceberg partitioned table") {
- withTable("p_str_tb", "p_int_tb") {
+ test("iceberg bucketed join") {
+ assume(isSparkVersionAtleast("3.4"))
Review Comment:
Yea, in my view the storage partitioned join was usable mostly from Spark
3.4. So, I didn't bother making it work for 3.3. Let me know if you think some
users are using spj on 3.3 and I can look more. Maybe in 3.5 follow up I will
add some documentation on README about SPJ support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
