rui-mo commented on code in PR #4797:
URL: https://github.com/apache/incubator-gluten/pull/4797#discussion_r1522595103
##########
backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/VeloxBackend.scala:
##########
@@ -151,9 +155,11 @@ object BackendSettings extends BackendSettingsApi {
if mapType.valueType.isInstanceOf[ArrayType] =>
"ArrayType as Value in MapType"
case StructField(_, stringType: StringType, _, metadata)
- if CharVarcharUtils
- .getRawTypeString(metadata)
- .getOrElse(stringType.catalogString) !=
stringType.catalogString =>
+ if GlutenConfig.getConf.forceOrcCharTypeScanFallbackEnabled &&
CHAR_TYPE_PATTERN
+ .findFirstIn(CharVarcharUtils
+ .getRawTypeString(metadata)
+ .getOrElse(stringType.catalogString))
Review Comment:
Maybe extract as a new function `isCharType`.
##########
gluten-core/src/main/scala/io/glutenproject/execution/BasicScanExecTransformer.scala:
##########
@@ -88,12 +89,29 @@ trait BasicScanExecTransformer extends LeafTransformSupport
with BaseDataSource
}
override protected def doValidateInternal(): ValidationResult = {
+ def addStringFields(
Review Comment:
nit: addStringFields -> appendStringFields, and maybe extract this function
out to generate all the fields needed for validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
