kerwin-zk commented on code in PR #4797:
URL: https://github.com/apache/incubator-gluten/pull/4797#discussion_r1522680710
##########
gluten-core/src/main/scala/io/glutenproject/execution/BasicScanExecTransformer.scala:
##########
@@ -88,12 +89,18 @@ trait BasicScanExecTransformer extends LeafTransformSupport
with BaseDataSource
}
override protected def doValidateInternal(): ValidationResult = {
+ var fields = schema.fields
+
+ this match {
+ case transformer: FileSourceScanExecTransformer =>
+ fields = appendStringFields(transformer.relation.schema, fields)
+ case transformer: HiveTableScanExecTransformer =>
+ fields = appendStringFields(transformer.getDataSchema, fields)
+ case _ =>
Review Comment:
@rui-mo I haven't encountered it here, but in theory, as long as there is a
native scan of orc, it is needed. I have added in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
