zhli1142015 commented on PR #5150: URL: https://github.com/apache/incubator-gluten/pull/5150#issuecomment-2024633762
Hello @FelixYBW , @PHILO-HE , @rui-mo , This pr failed with error `Validation failed due to exception caught at file:SubstraitToVeloxPlanValidator.cc line:804 function:validate, thrown from file:ExprCompiler.cpp line:426 function:compileRewrittenExpression, reason:Found incompatible return types for 'bitwise_not' (BIGINT vs. TINYINT) for input types (TINYINT)..` this is very wierd as the function with correct signatures are already added in Velox. In Gluten we reigister presto fucntion first then spark functions. Is this because of the overwrite behavior from `registerStatefulVectorFunction`? But for simple functions they use vectors to store function signatures `registerFunctionInternal`. So for vector functions the last signaturewins, but for simple functions, the first wins. This is too confusing, should we make them same behaviors, maybe set `overwrite` as false for all spark vector functions, and register spark fucntions first in gluten? I saw there are several discussions and fixes for such issue, please suggest any guidence to handle such case. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
