zhli1142015 commented on PR #5150: URL: https://github.com/apache/incubator-gluten/pull/5150#issuecomment-2024931008
> @zhli1142015, So Velox is somehow trying to use prestosql's `bitwise_not`, not the one you added after the below resolving. https://github.com/facebookincubator/velox/blob/main/velox/expression/SimpleFunctionRegistry.cpp#L143 > > We always let presto function registered firstly, thus spark function registration can overwrite the previous one if they have same signature (including return type, see [link](https://github.com/facebookincubator/velox/blob/main/velox/expression/SimpleFunctionRegistry.cpp#L48)). So in your case, the overwriting does not happen. > > We have a discussion for some other conflict cases at #4759 where two fix approaches are suggested. Looks the overwrite happens only if the function signature exactly matches. https://github.com/facebookincubator/velox/blame/0c86a0aedb90bfa966087def7551a40fc3571a01/velox/core/SimpleFunctionMetadata.h#L498-L515C4 Is this some regression? I test bitwise_and, looks it also failed with same error. `Validation failed due to exception caught at file:SubstraitToVeloxPlanValidator.cc line:804 function:validate, thrown from file:ExprCompiler.cpp line:426 function:compileRewrittenExpression, reason:Found incompatible return types for 'bitwise_and' (BIGINT vs. TINYINT) for input types (TINYINT, TINYINT)..` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
