rui-mo commented on code in PR #5240:
URL: https://github.com/apache/incubator-gluten/pull/5240#discussion_r1549362852
##########
backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala:
##########
@@ -1236,4 +1238,52 @@ class TestOperator extends
VeloxWholeStageTransformerSuite {
}
}
}
+
+ test("Cast date to string") {
+ withTempPath {
+ path =>
+ Seq("2023-01-01", "2023-01-02", "2023-01-03")
+ .toDF("dateColumn")
+ .select(to_date($"dateColumn", "yyyy-MM-dd").as("dateColumn"))
+ .write
+ .parquet(path.getCanonicalPath)
+
spark.read.parquet(path.getCanonicalPath).createOrReplaceTempView("view")
+ runQueryAndCompare("SELECT cast(dateColumn as string) from view") {
+ checkGlutenOperatorMatch[ProjectExecTransformer]
+ }
+ }
+ }
+
+ test("Cast date to timestamp") {
+ withTempPath {
+ path =>
+ Seq("2023-01-01", "2023-01-02", "2023-01-03")
+ .toDF("dateColumn")
+ .select(to_date($"dateColumn", "yyyy-MM-dd").as("dateColumn"))
+ .write
+ .parquet(path.getCanonicalPath)
+
spark.read.parquet(path.getCanonicalPath).createOrReplaceTempView("view")
+ runQueryAndCompare("SELECT cast(dateColumn as timestamp) from view") {
+ checkGlutenOperatorMatch[ProjectExecTransformer]
+ }
+ }
+ }
+
+ test("cast date to timestamp with timezone") {
+ sql("SET spark.sql.session.timeZone = America/Los_Angeles")
+ val dfWithLA = sql("SELECT cast(date'2023-01-02 01:01:01' as timestamp) as
ts")
+
+ sql("SET spark.sql.session.timeZone = Asia/Shanghai")
+ val dfWithSH = sql("SELECT cast(date'2023-01-02 01:01:01' as timestamp) as
ts")
+
+ // They should be the same because date in spark represents the day
+ checkAnswer(dfWithLA, Row(Timestamp.valueOf("2023-01-02 00:00:00")))
Review Comment:
Maybe, what we need is not to adjust time zone as what has been done at
https://github.com/facebookincubator/velox/blob/main/velox/expression/CastExpr.cpp#L184-L187.
This requires separating Spark logic with Presto as cast is used by both. To
achieve that, maybe you want to create a cast hook.
https://github.com/facebookincubator/velox/blob/main/velox/expression/CastHooks.h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
