PHILO-HE commented on code in PR #5240:
URL: https://github.com/apache/incubator-gluten/pull/5240#discussion_r1550938563
##########
backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala:
##########
@@ -1236,4 +1238,53 @@ class TestOperator extends
VeloxWholeStageTransformerSuite {
}
}
}
+
+ test("Cast date to string") {
+ withTempPath {
+ path =>
+ Seq("2023-01-01", "2023-01-02", "2023-01-03")
+ .toDF("dateColumn")
+ .select(to_date($"dateColumn", "yyyy-MM-dd").as("dateColumn"))
+ .write
+ .parquet(path.getCanonicalPath)
+
spark.read.parquet(path.getCanonicalPath).createOrReplaceTempView("view")
+ runQueryAndCompare("SELECT cast(dateColumn as string) from view") {
+ checkGlutenOperatorMatch[ProjectExecTransformer]
+ }
+ }
+ }
+
+ test("Cast date to timestamp") {
+ withTempPath {
+ path =>
+ Seq("2023-01-01", "2023-01-02", "2023-01-03")
+ .toDF("dateColumn")
+ .select(to_date($"dateColumn", "yyyy-MM-dd").as("dateColumn"))
+ .write
+ .parquet(path.getCanonicalPath)
+
spark.read.parquet(path.getCanonicalPath).createOrReplaceTempView("view")
+ runQueryAndCompare("SELECT cast(dateColumn as timestamp) from view") {
+ checkGlutenOperatorMatch[ProjectExecTransformer]
+ }
+ }
+ }
+
+ test("cast date to timestamp with timezone") {
+ sql("SET spark.sql.session.timeZone = America/Los_Angeles")
+ val dfInLA = sql("SELECT cast(date'2023-01-02 01:01:01' as timestamp) as
ts")
+
+ sql("SET spark.sql.session.timeZone = Asia/Shanghai")
+ val dfInSH = sql("SELECT cast(date'2023-01-02 01:01:01' as timestamp) as
ts")
+
+ // They should be different because timestamp in spark is with timezone
Review Comment:
Please revise this comment, like the below:
"Casting date to timestamp considers configured local timezone. There is
16-hour difference between America/Los_Angeles & Asia/Shanghai"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
