Yohahaha commented on code in PR #5283:
URL: https://github.com/apache/incubator-gluten/pull/5283#discussion_r1554795692
##########
gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/joins/GlutenBroadcastJoinSuite.scala:
##########
@@ -74,5 +72,6 @@ class GlutenBroadcastJoinSuite extends BroadcastJoinSuite
with GlutenTestsCommon
.config("spark.unsafe.exceptionOnMemoryLeak", "true")
.getOrCreate()
}
+ super.beforeAll()
Review Comment:
SparkContext only initializes once in JVM, before this patch, this suites
only run with vanilla Spark, because `super.beforeAll` generate a SparkContext
instance without Gluten plugins. After this patch, we can inject Gluten's
config before SparkContext initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
