zhztheplayer commented on code in PR #5283:
URL: https://github.com/apache/incubator-gluten/pull/5283#discussion_r1554959407
##########
gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/joins/GlutenBroadcastJoinSuite.scala:
##########
@@ -74,5 +72,6 @@ class GlutenBroadcastJoinSuite extends BroadcastJoinSuite
with GlutenTestsCommon
.config("spark.unsafe.exceptionOnMemoryLeak", "true")
.getOrCreate()
}
+ super.beforeAll()
Review Comment:
Thanks for the explanation. Though it's so implicit to me if the call order
of `super.beforeAll()` matters. Should we add some comments in code to explain
that?
And maybe we should also check other test files to see if similar issues
exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
