zhztheplayer commented on PR #5698: URL: https://github.com/apache/incubator-gluten/pull/5698#issuecomment-2105459686
> Please, do not make things complex... I strongly suggest revert previous pr and just inherit case class for now. I don't agree. Please let me know if any Scala project with good code quality has case-class inheritance. To me doing case-class inheritance makes thing complex. I know Scala doesn't do well for extensibility of case-class, I don't like this limitation either. But if it's the principle of Scala, I'd follow it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
