ulysses-you commented on PR #5698: URL: https://github.com/apache/incubator-gluten/pull/5698#issuecomment-2105518908
My point is that if there is an actually issue with case class, I'm fine to change it since it is a fix, otherwise just add a todo and leave it. I searched Spark code repo, and really find [a case](https://github.com/apache/spark/blob/f699f556d8a09bb755e9c8558661a36fbdb42e73/sql/catalyst/src/main/scala/org/apache/spark/sql/sources/filters.scala#L361-L368)... is it valid for you @zhztheplayer ? Yes, Spark master branch has a trait for this but older version did not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
