EpsilonPrime commented on code in PR #5398:
URL: https://github.com/apache/incubator-gluten/pull/5398#discussion_r1602259409
##########
gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto:
##########
@@ -495,6 +504,7 @@ message Rel {
GenerateRel generate = 17;
WriteRel write = 18;
TopNRel top_n = 19;
+ WindowGroupLimitRel windowGroupLimit = 20;
Review Comment:
Substrait already has a field #20. This means that your Substrait is not
going to be compatible with any other Substrait consumers or tools. The
Substrait project is open to adding new relations -- all it takes is a PR,
issue, or email to start the discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
