jinchengchenghh commented on code in PR #5752:
URL: https://github.com/apache/incubator-gluten/pull/5752#discussion_r1602573722
##########
gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionTransformer.scala:
##########
@@ -18,6 +18,15 @@ package org.apache.gluten.expression
import org.apache.gluten.substrait.expression.ExpressionNode
+import org.apache.spark.sql.catalyst.expressions.Expression
+import org.apache.spark.sql.types.DataType
+
trait ExpressionTransformer {
Review Comment:
Does this one still should be used? Can we use
`ExpressionTransformerWithOrigin` to replace `ExpressionTransformer` and rename
`ExpressionTransformerWithOrigin` to `ExpressionTransformer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
