ulysses-you commented on code in PR #5752:
URL: https://github.com/apache/incubator-gluten/pull/5752#discussion_r1604240574
##########
gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionTransformer.scala:
##########
@@ -18,6 +18,15 @@ package org.apache.gluten.expression
import org.apache.gluten.substrait.expression.ExpressionNode
+import org.apache.spark.sql.catalyst.expressions.Expression
+import org.apache.spark.sql.types.DataType
+
trait ExpressionTransformer {
Review Comment:
yea, there are a lot of exprs else.. `ChildTransformer`,
`NamedLambdaVariableTransformer`, and some of those seem do not have origin,
e.g., `UDFExpression`. If you prefer make all ExpressionTransformer hold
origin, I can make the change in a new pr since it may need many code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
