zhztheplayer commented on code in PR #5767:
URL: https://github.com/apache/incubator-gluten/pull/5767#discussion_r1606158926
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -73,6 +75,22 @@ import scala.collection.mutable.ListBuffer
class VeloxSparkPlanExecApi extends SparkPlanExecApi {
+ /** The columnar-batch type this backend is using. */
+ override def batchType: Convention.BatchType = {
+ VeloxBatch
+ }
+
+ /**
+ * Overrides
[[org.apache.gluten.extension.columnar.transition.ConventionFunc]] Gluten is
using to
+ * determine the convention (its row-based processing / columnar-batch
processing support) of a
+ * plan with a user-defined function that accepts a plan then returns batch
type it outputs.
+ */
+ override def batchTypeFunc(): BatchOverride = {
+ case i: InMemoryTableScanExec
+ if
i.relation.cacheBuilder.serializer.isInstanceOf[ColumnarCachedBatchSerializer]
=>
+ VeloxBatch
Review Comment:
cc @ulysses-you
##########
backends-velox/src/main/scala/org/apache/gluten/execution/datasource/v2/ArrowBatchScanExec.scala:
##########
@@ -31,6 +33,10 @@ case class ArrowBatchScanExec(original: BatchScanExec)
@transient lazy val batch: Batch = original.batch
+ override protected def batchType0(): Convention.BatchType = {
+ ArrowBatch
Review Comment:
cc @jinchengchenghh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
