rui-mo commented on code in PR #5767:
URL: https://github.com/apache/incubator-gluten/pull/5767#discussion_r1606338601
##########
backends-velox/src/main/scala/org/apache/gluten/execution/datasource/v2/ArrowBatchScanExec.scala:
##########
@@ -31,6 +33,10 @@ case class ArrowBatchScanExec(original: BatchScanExec)
@transient lazy val batch: Batch = original.batch
+ override protected def batchType0(): Convention.BatchType = {
Review Comment:
nit: the name batchType0 is a bit confusing, and can we use a more
informative name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
