WangGuangxin commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2128341544
Do we still need `preferredBuildSide` in `ShuffledHashJoinExecTransformer`? https://github.com/apache/incubator-gluten/blob/main/backends-velox/src/main/scala/org/apache/gluten/execution/ShuffledHashJoinExecTransformer.scala#L78 In fact, I'm quite confused this logic here. In fact, if we can choose the right build side, why prefer new build side based on pattern there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
