WangGuangxin commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2128429008
> > I am not sure why JoinSelectionOverrides does not have the judgment of size. > > @rui-mo Do you have some contexts on this difference? If Velox backend doesn't require for the strategy then we may be able to move it to CH module. IIUC, `JoinSelectionOverride` does two things: 1. force shuffled hash join 2. fallback if there are continue joins ( TPC-DS badcase?) Both of them can be ( and should be ?) moved to `ColumnOverrides`. In fact, if we reuse the `JoinSelection` rule in Spark instead of override it, it can naturally support choose build side by size, right? cc @zml1206 @rui-mo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
