taiyang-li commented on code in PR #5839:
URL: https://github.com/apache/incubator-gluten/pull/5839#discussion_r1613176434
##########
gluten-core/src/main/java/org/apache/gluten/vectorized/GeneralOutIterator.java:
##########
@@ -60,10 +61,18 @@ public final void close() {
}
}
+ public final void cancel() {
Review Comment:
@rui-mo I added a new interface for GeneralOutIterator. For velox it is by
default empty. It is needed by clickhouse backend to cancel the pipeline before
task is killed, to ensure some resources are released gracefully. Could you
help review the change? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
